Fix frequency calculation at logscale sweeps #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case that
logarithmic sweepis enabled in the sweep settings, the (internally linearly sampled) segments of 101 data points do not have a proper logarithmic spacing. When multiple segments are used, the quotient of end_frequency by start_frequency for all segments should be the same. Also a small error in the get_frequency() iterator is fixed.See also: #701
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
In case that
logarithmic sweepis enabled in the sweep settings, the (internally linearly sampled) segments of 101 data points do not have a proper logarithmic spacing.#701
What is the new behavior?
Frequencies with the correct spacing are calculated.
Does this introduce a breaking change?
Other information