Add new s21 markers for |Z| and R+jX #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjordans
suggested changes
Apr 23, 2021
NanoVNASaver/Marker/Widget.py
Outdated
| @@ -351,3 +351,7 @@ def updateLabels(self, | |||
| self.label['s21phase'].setText(format_phase(s21.phase)) | |||
| self.label['s21polar'].setText( | |||
| str(round(abs(s21.z), 2)) + "∠" + format_phase(s21.phase)) | |||
| self.label['s21magshunt'].setText(format_magnitude(abs(s21.shuntImpedance()))) | |||
| self.label['s21magseries'].setText(format_magnitude(abs(s21.seriesImpedance()))) | |||
| self.label['s21realimagshunt'].setText(format_complex_imp(s21.shuntImpedance())) | |||
There was a problem hiding this comment.
The format_complex_imp() will need its optional second argument set to True to properly display negative real numbers here (same holds for the next line)
There was a problem hiding this comment.
Updated, ammended the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new markers for
S21 |Z| shunt
S21 |Z| series
S21 R+jX shunt
S21 R+jX series
issue #165