Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak examples/check.ctl under MPI #141

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

thchr
Copy link
Contributor

@thchr thchr commented Feb 3, 2022

I realized that the changes from #134 broke make check when compiled with MPI, because the symmetry-eigenvalue tests would try to run but fail because the code throws a transformed_overlap(..) is not yet implemented for MPI error.

This just disables that check if (using-mpi?) is true.

@thchr
Copy link
Contributor Author

thchr commented Feb 3, 2022

d0eaf7f is just an unrelated drive-by fix to some typos I noticed I had made in the docs.

@thchr
Copy link
Contributor Author

thchr commented Feb 4, 2022

Coincidentally - and not exactly relatedly, but figured I'd ask while I already have your attention - I have been meaning to ask:

If I wanted to make the compute_symmetry, etc. functions accessible in meep's Python interface for mpb, what would the steps be?
I had naively thought it might be possible to expose the C-functions from MPB via meep's python/solver.py - but looking in libpympb/pympb.cpp, I get the impression that virtually all the Python-accessible MPB methods are reimplemented from scratch there? Is that the only way to go about it, i.e. duplicate everything in the meep repo? (I don't have prior experience with SWIG, unfortunately)

@stevengj
Copy link
Collaborator

stevengj commented Feb 4, 2022

Anything in mpb/mpb/* is Scheme-dependent and not callable as a library, so unfortunately it needs to be ported to https://github.com/NanoComp/meep/blob/master/libpympb/pympb.cpp to be called from Python

@stevengj stevengj merged commit 727add2 into NanoComp:master Feb 4, 2022
@thchr thchr deleted the patch-1 branch February 4, 2022 13:20
@thchr
Copy link
Contributor Author

thchr commented Feb 4, 2022

Anything in mpb/mpb/* is Scheme-dependent and not callable as a library, so unfortunately it needs to be ported to https://github.com/NanoComp/meep/blob/master/libpympb/pympb.cpp to be called from Python

Okay, thanks for clarifying that 👍. I'll try to port the code to the meep repo one of these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants