Jupyter notebooks for basics and binary-grating tutorial examples #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oskooi
commented
Mar 27, 2019
oskooi
commented
- adds 8 Jupyter notebooks to python/examples for Tutorial/Basics and Tutorial/Mode Decomposition (binary grating only); eventually all tutorial examples will have an associated notebook
- documentation for WIP: periodic green's functions #769; test will be added separately once discretization artifacts in get_dft_array #784 is resolved
- minor updates to docs
stevengj
reviewed
Mar 27, 2019
doc/docs/Python_Tutorials/Basics.md
Outdated
| @@ -26,7 +26,7 @@ For our first example, let's examine the field pattern excited by a localized [C | |||
|
|
|||
| ### A Straight Waveguide | |||
|
|
|||
| The simulation script is in [examples/straight-waveguide.py](https://github.com/NanoComp/meep/blob/master/python/examples/straight-waveguide.py). | |||
| The simulation script is in [examples/straight-waveguide.py](https://github.com/NanoComp/meep/blob/master/python/examples/straight-waveguide.py). The notebook is [examples/straight-waveguide.ipynb](https://github.com/NanoComp/meep/blob/master/python/examples/straight-waveguide.ipynb) | |||
There was a problem hiding this comment.
Would be nicer to link via nbviewer, e.g. https://nbviewer.jupyter.org/github/NanoComp/meep/blob/master/python/examples/straight-waveguide.ipynb
There was a problem hiding this comment.
i.e. replace https://github.com with https://nbviewer.jupyter.org/github in the notebook links
There was a problem hiding this comment.
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…noComp#786) * Jupyter notebooks for Basics and binary grating tutorial examples * more details on nperiods * nbviewer links * nbviewer links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.