Fix memory leaks in Simulation.get_eigenmode and enable building without MPB #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should make sure that Meep+Python compiles even if MPB is not installed. This might involve adding |
|
Would be nice to have a regression test for this. Maybe just compile Meep with MPB disabled ( |
ChristopherHogan
changed the title
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…out MPB (NanoComp#558) * Fix memory leaks in Simulation.get_eigenmode * Enable building without MPB * Wrong macro name in meep.i * Build without MPB in travis * Fix .travis syntax * Include config.h * Typo * Stub out _get_eigenmode and pass preprocessor directives through SWIG * Make config.h available to SWIG preprocessor * Run make clean before building without MPB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were actually 3 leaks here.
Gkandkdomare now returned directly as Python objects (Gkvia_get_eigenmode_Gkandkdomis a numpy array passed as an output argument to_get_eigenmode), so Python gc will handle them properly. Also added a destructor that callsdestroy_eigenmode_dataformeep::eigenmode_data.@stevengj @oskooi