Fix non Hermitian epsilon case #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like we should throw an error if nonzero imaginary parts are passed in this case? |
|
Added checks for imaginary parts of epsilon and mu offdiags when not using Hermitian epsilon. For mediums, the check is performed once for the default material and once for each geometric object's material. User and file materials are checked on every |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Fix non Hermitian epsilon case * Add check_offdiag when we're not using Hermitian eps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269. Only use the real part of
<epsilon|mu>_offdiagwhen MPB wasn't built withWITH_HERMITIAN_EPSILON. I recall doing this before, but it must have been undone by a rebase.@stevengj @oskooi