Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in check for invalid sources at r=0 in cylindrical coordinates #2459

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Apr 4, 2023

Fixes a bug introduced in #2392 which currently prevents placing an Ep source at r=0 for m=1 which should be valid. Instead, the master repository aborts with this error:

RuntimeError: meep: Not possible to place a source at r=0 in cylindrical coordinates for m = 1.

(It would have been good to have added a unit test in #2392 for this feature involving some kind of exception handling.)

@oskooi oskooi added the bug label Apr 4, 2023
@oskooi oskooi merged commit b481302 into NanoComp:master Apr 5, 2023
@oskooi oskooi deleted the cyl_check_source_bugfix branch April 5, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant