Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hinting #2176

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Type hinting #2176

merged 2 commits into from
Jul 30, 2022

Conversation

thomasdorch
Copy link
Contributor

  • Adding type hints to visualization.py
  • Import visualization in simulation.py only when using the plotting methods in Simulation to avoid circular imports
  • Fixed a typo

@codecov-commenter
Copy link

Codecov Report

Merging #2176 (5f0ad2e) into master (c19b3dc) will decrease coverage by 0.20%.
The diff coverage is 49.42%.

@@            Coverage Diff             @@
##           master    #2176      +/-   ##
==========================================
- Coverage   73.29%   73.09%   -0.21%     
==========================================
  Files          17       17              
  Lines        4891     4906      +15     
==========================================
+ Hits         3585     3586       +1     
- Misses       1306     1320      +14     
Impacted Files Coverage Δ
python/simulation.py 76.85% <25.00%> (-0.10%) ⬇️
python/visualization.py 42.65% <50.60%> (-0.76%) ⬇️

@stevengj stevengj merged commit 442b921 into NanoComp:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants