Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore PML plotting with cartesian coordinates #1884

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

smartalecH
Copy link
Collaborator

Fixes #1880.

Cartesian:

image

image

@oskooi oskooi self-requested a review January 5, 2022 02:31
Copy link
Collaborator

@oskooi oskooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #1884 (930bee4) into master (d00febd) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   73.23%   73.16%   -0.08%     
==========================================
  Files          17       17              
  Lines        4914     4919       +5     
==========================================
  Hits         3599     3599              
- Misses       1315     1320       +5     
Impacted Files Coverage Δ
python/visualization.py 45.08% <66.66%> (ø)
python/adjoint/connectivity.py 10.09% <0.00%> (-0.49%) ⬇️

@stevengj stevengj merged commit efe3b4b into NanoComp:master Jan 5, 2022
@smartalecH smartalecH deleted the i1880 branch March 22, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect PMLs for Cartesian coordinates in plot2D
4 participants