Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for reciprocity of mode coefficients #1802

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Oct 27, 2021

Adds a new unit test based on the discussion and results from #1773 (comment).

@codecov-commenter
Copy link

Codecov Report

Merging #1802 (c7ebc14) into master (577109d) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1802      +/-   ##
==========================================
- Coverage   73.90%   73.68%   -0.23%     
==========================================
  Files          17       17              
  Lines        4913     4913              
==========================================
- Hits         3631     3620      -11     
- Misses       1282     1293      +11     
Impacted Files Coverage Δ
python/simulation.py 76.35% <0.00%> (-0.39%) ⬇️
python/geom.py 93.81% <0.00%> (-0.35%) ⬇️

@stevengj stevengj merged commit dd4662f into NanoComp:master Oct 27, 2021
@oskooi oskooi deleted the mode_coeffs_reciprocity branch October 27, 2021 20:02
mawc2019 pushed a commit to mawc2019/meep that referenced this pull request Nov 3, 2021
* unit test for reciprocity of mode coefficients

* second test for changing DFT monitors and fixed k-point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants