additional documentation for MaterialGrid #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartalecH
reviewed
Sep 19, 2021
smartalecH
approved these changes
Sep 19, 2021
|
For clarity, I added a comment to |
|
Maybe the figure should show "Nx=5" and "Ny=4" |
Done. |
This was referenced Sep 27, 2021
fix off-by-one bug in dimensions of fixed-resolution MaterialGrid for adjoint-solver functions
#1769
Merged
4 tasks
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* additional documentation for MaterialGrid * use a higher resolution design grid and add comment to explain number of grid points * slight tweaks to wording and update schematic * annotate Nx and Ny in schematic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional documentation for the
MaterialGridto mention that nonuniform grids are supported including a new figure showing the actual location of the grid points for a 2d example.Also includes a fix for an off-by-one bug in the unit test
test_material_grid.pyin which the resolution of the grid did not exactly match what was specified.