add multithreading check to CI #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To facilitate #1628's attempt to add support for multithreading via OpenMP, this PR adds multithreading to 2/4 test environments (serial and MPI) of the CI. I verified using the output of
config.logfrom the actual CI runs that the GCC compiler supports OpenMP (and that it therefore does not need to be installed separately).The current default behavior when compiling with the
--with-openmpflag is to use two threads:meep/configure.ac
Lines 261 to 264 in 3da5613
We may want to consider changing this default value as part of the CI as well.