decimation option for remaining DFT functions #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
===========================================
- Coverage 73.35% 25.53% -47.83%
===========================================
Files 13 13
Lines 4530 4535 +5
===========================================
- Hits 3323 1158 -2165
- Misses 1207 3377 +2170
|
|
Unit tests and documentation have been added. This is ready to be merged. |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* add decimation factor to add_dft_flux * some fixes * fixes * fixes, unit tests, docs * update markdown pages for user manual * increase tolerance of failing unit test in test_bend_flux.py * fix add_dft_near2far function header
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* add decimation factor to add_dft_flux * some fixes * fixes * fixes, unit tests, docs * update markdown pages for user manual * increase tolerance of failing unit test in test_bend_flux.py * fix add_dft_near2far function header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1678.
#1684 introduced a new
decimation_factorparameter for theadd_dft_fieldsfunction to enable decimation of the DFT time-series updates. This PR adds thedecimation_factoroption to the five remaining DFT functions:add_flux,add_near2far,add_mode_monitor,add_energy, andadd_forces. Another DFT functiondft_ldoshandles the DFT fields differently than the other functions (i.e., it does not initialize the fields usingfields::add_dft) and will be dealt with in a separate PR.This PR still requires unit tests and documentation before it can be merged.