Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve autoconf handling for HDF5 library. #1598

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Improve autoconf handling for HDF5 library. #1598

merged 1 commit into from
Jun 9, 2021

Conversation

ahoenselaar
Copy link
Contributor

  • Use pkg-config to detect HDF5 when available.
  • Add CPPFLAGS to account for HDF5 library headers.

These steps improve the chances of locating the library of Ubuntu systems and other modern distributions.

Implementation:

  • Optimistically update LIBS and CPPFLAGS from pkg-config or by assuming a default
  • Perform AC_CHECKs
  • Revert LIBS and CPPFLAGS if any of the checks fail.

stevengj
stevengj reviewed Jun 9, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Jun 9, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Jun 9, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Jun 9, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
stevengj
stevengj reviewed Jun 9, 2021
View reviewed changes
configure.ac Outdated Show resolved Hide resolved
@ahoenselaar
Improve autoconf handling for HDF5 library.
ea406f6 
*  Use pkg-config to detect HDF5 when available.
*  Add CPPFLAGS to account for HDF5 library headers.

These steps improve the chances of locating the library of Ubuntu
systems and other modern distributions.
@stevengj stevengj merged commit 36b647d into NanoComp:master Jun 9, 2021
@ahoenselaar ahoenselaar deleted the achdf5 branch June 9, 2021 23:42
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@ahoenselaar
Improve autoconf handling for HDF5 library. (NanoComp#1598)
b6d9239 
*  Use pkg-config to detect HDF5 when available.
*  Add CPPFLAGS to account for HDF5 library headers.

These steps improve the chances of locating the library of Ubuntu
systems and other modern distributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoenselaar @stevengj