Fix use-after-free issue with the global 'default_material' (issue 1483) #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Gadepalli <[email protected]>
stevengj
reviewed
Jun 3, 2021
stevengj
reviewed
Jun 3, 2021
|
|
||
| user_func = from.user_func; | ||
| // NOTE: the user_data field here opaque/void - so this is the best we can do. | ||
| user_data = from.user_data; |
There was a problem hiding this comment.
This may be problematic — we may need to increment a Python reference count.
There was a problem hiding this comment.
Not a regression, however — filed as #1589
stevengj
reviewed
Jun 3, 2021
stevengj
reviewed
Jun 3, 2021
…isting update_weights too)
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…83) (NanoComp#1583) * Fix use-after-free issue with the global 'default_material' (issue 1483) Signed-off-by: Krishna Gadepalli <[email protected]> * Make all copy_from methods take const ref. * use size_t instead of 'int' when computing size for memcpy (update existing update_weights too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krishna Gadepalli [email protected]
Closes #1483.