additional improvements for MaterialGrid

[oskooi]

Additional improvements to MaterialGrid following @stevengj's two unresolved comments in #1508:

• rename design_parameters to weights
• rename U_SUM to U_MEAN

Also includes more fixes and tweaks for the docstrings.

Additionally, this PR fixes a bug in libpympb/mpb.h related to the name of an imported header file that was discovered during the course of development:

meep/libpympb/pympb.hpp

Line 8 in a079d9b

#include "meepgeom.hpp"

The preprocessor for GCC was loading meepgeom.hpp found in the system directory /usr/local/include/meep rather than the file in the source tree (from the meep/src subdirectory). As a result, this was causing an error during make because design_parameters had been renamed to weights in meepgeom.cpp but not in meepgeom.hpp. The fix involved changing this line to:

#include "../src/meepgeom.hpp"

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[oskooi]

Configure command:

./configure --enable-maintainer-mode --enable-shared --with-mpi PYTHON=python3.5 LDFLAGS=-L/usr/lib/x86_64-linux-gnu/hdf5/openmpi -L/usr/local/lib -Wl,-rpath,/usr/lib/x86_64-linux-gnu/hdf5/openmpi:/usr/local/lib CPPFLAGS=-I/usr/include/hdf5/openmpi -I/usr/local/include

[oskooi]

RPATH_FLAGS="-Wl,-rpath,/usr/lib/x86_64-linux-gnu/hdf5/openmpi:/usr/local/lib"
MY_LDFLAGS="-L/usr/lib/x86_64-linux-gnu/hdf5/openmpi -L/usr/local/lib ${RPATH_FLAGS}"
MY_CPPFLAGS="-I/usr/include/hdf5/openmpi -I/usr/local/include"

sh autogen.sh --enable-shared --with-mpi PYTHON=python3.5 LDFLAGS="${MY_LDFLAGS}" CPPFLAGS="${MY_CPPFLAGS}"
make

[stevengj]

meepgeom.hpp is installed in /usr/local/include/meep, not /usr/local/include, so -I/usr/local/include won't cause it to be found by #include "meepgeom.h"

Furthermore, gcc searches the -I paths in left to right order. This means that the -I$(top_srcdir)/src specified in AM_CPPFLAGS by libpympb/Makefile.am will take precedence over any -I flags you specify in CPPFLAGS, because CPPFLAGS appears after AM_CPPFLAGS in automake's flag ordering.

So, I don't think that change is correct.