re-instate undocumented get_array_slice_dimensions in Python interface #1464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1456 removed
get_array_slice_dimensions
from the Python interface which unfortunately was discovered afterwards to be used by the adjoint solver in a couple of places:meep/python/adjoint/optimization_problem.py
Lines 191 to 195 in 37117fe
meep/python/adjoint/optimization_problem.py
Lines 408 to 415 in 37117fe
Rather than modify the above lines to use the low-level
_get_array_slice_dimensions
, this PR simply re-instatesget_array_slice_dimensions
(in its original form). Note that this is an internal function used only by the adjoint solver that is not documented in the user manual.We will need to do a version 1.17.1 release after this is merged since 1.17.0 broke the adjoint solver.
Also, it would be good to add some unit tests for the adjoint solver to prevent these types of fixes in the future.