Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak in get_array_metadata #1447

Merged
merged 2 commits into from
Dec 16, 2020
Merged

fix memory leak in get_array_metadata #1447

merged 2 commits into from
Dec 16, 2020

Conversation

stevengj
Copy link
Collaborator

@stevengj stevengj commented Dec 9, 2020

May help with #1431?

@ianwilliamson
Copy link
Contributor

May help with #1431?

My understanding of the output in #1431 is that the heap overflow is occurring somewhere inside of collapse_array. Rerunning asan with the fix introduced here still produces the same output as in #1431. At the moment, I can not confirm whether this fixes a separate memory leak (though it certainly looks like weights should be freed).

oskooi
oskooi reviewed Dec 10, 2020
View reviewed changes
src/array_slice.cpp Outdated Show resolved Hide resolved
@stevengj stevengj merged commit 01d3532 into master Dec 16, 2020
@stevengj stevengj deleted the memleak branch December 16, 2020 02:01
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@stevengj
fix memory leak in get_array_metadata (NanoComp#1447)
8661498 
* fix memory leak in get_array_metadata

* Update array_slice.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartalecH smartalecH smartalecH left review comments

@oskooi oskooi oskooi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevengj @ianwilliamson @oskooi @smartalecH