WIP: complex ε and μ output #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These parameters should be renamed from |
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* convert chi1inv from double to complex<double> * update test * add docs * correction * correction Co-authored-by: Steven G. Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1108
There is just one thing that needs to be resolved:
output_epsilonandget_epsilonoutput/return a complex array only when ω≠0 whereas conductivity or susceptibility needs to be present as well. I wasn't sure how to do this cleanly.The following two lines need to be modified:
https://github.com/oskooi/meep/blob/a11f1982f8f487676b1f2be8c927a9b4bb53ce1d/python/simulation.py#L2013
https://github.com/oskooi/meep/blob/a11f1982f8f487676b1f2be8c927a9b4bb53ce1d/src/h5fields.cpp#L391