Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meep make fails to compile structure_dump.cpp #1701

Closed
FiodarM opened this issue Jul 26, 2021 · 1 comment · Fixed by #1702
Closed

Meep make fails to compile structure_dump.cpp #1701

FiodarM opened this issue Jul 26, 2021 · 1 comment · Fixed by #1702

Comments

@FiodarM
Copy link

FiodarM commented Jul 26, 2021

I am trying to build meep on master node of a cluster running Red Hat Linux.
I build parallel version with OpenMPI.
I was able to configure meep with ./configure (config.log), but make fails (make.log) on compiling structure_dump.cpp with the error:

structure_dump.cpp:427:110: error: cannot convert ‘const meep::split_plane’ to ‘meep::direction’ in initialization
binary_partition::binary_partition(const binary_partition& other) : proc_id{other.proc_id}, plane{other.plane} {
                                                                                                             ^

I tried to build both with master branch and release 1.19 and faced the same error.
Possibly relevant environment data:

  • gcc-4.8.5
  • hdf5-1.10.7
  • openmpi-4.1.1
  • libctl-4.5.0

Any clue on what is going on?
Thanks
ahoenselaar added a commit to ahoenselaar/meep that referenced this issue Jul 26, 2021
@ahoenselaar
Fix the binary_partition copy constructor.
5cbc8be 
Prevents issues with older compilers.
\NanoComp#1683 NanoComp#1701
@ahoenselaar ahoenselaar mentioned this issue Jul 26, 2021
Merged
@FiodarM
Copy link
Author

FiodarM commented Jul 26, 2021

@ahoenselaar Thank you very much for the fix! Worked for me.

@FiodarM FiodarM closed this as completed Jul 27, 2021
stevengj added a commit that referenced this issue Jul 27, 2021
@ahoenselaar @stevengj
Fix the binary_partition copy constructor. (#1702)
9abd84e 
* Fix the `binary_partition` copy constructor.

Prevents issues with older compilers.
\#1683 #1701

* Update src/structure_dump.cpp

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Steven G. Johnson <[email protected]>
stevengj added a commit that referenced this issue Jul 30, 2021
@mochen4 @ahoenselaar
@stevengj @oskooi
Enable nonzero k_point in adjoint solver (#1705)
5011d4d 
* fix factor 2

* fix

* fix

* fix

* kpoint

* fix

* Fix the `binary_partition` copy constructor. (#1702)

* Fix the `binary_partition` copy constructor.

Prevents issues with older compilers.
\#1683 #1701

* Update src/structure_dump.cpp

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Steven G. Johnson <[email protected]>

* single precision test tol

* single precision test tol

* Fix factor of 2 in adjoint gradients when not using complex fields (#1704)

* fix factor 2

* fix

* fix

* fix

* single precision test tol

* single precision test tol

* Update python/adjoint/objective.py

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Mo Chen <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>

* assertVectorsClose works for scalars as well as vectors (#1712)

* assertVectorsClose works for scalars as well as vectors

* rename ApproxComparisonMixin -> ApproxComparisonTestCase, since it is a subclass of TestCase, and use it as such

* add --with-coverage to control usage of Python coverage tests (#1713)

* add --with-coverage to control usage of Python coverage tests

* move  --with-coverage  to correct CI line

* flush subnormals on x86 (#1709)

* flush subnormals on x86

* less aggressive error threshold in single precision

* increase single-precision tolerance

* update tols in test_array_metadata

* update for assertVectorsClose rename

* lower tolerance in single precision

* Lower tolerance of CW and eigenfrequency solver tests for single precision (#1714)

* lower tolerance of CW and eigenfrequency solver tests for single precision

* remove change in default argument from Python wrappers

* fix factor 2

* fix

* kpoint

* fix

* single precision test tol

* single precision test tol

* using real

* using real

* fix rebase

* fix

* fix

Co-authored-by: Mo Chen <[email protected]>
Co-authored-by: Andreas Hoenselaar <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>
Co-authored-by: Ardavan Oskooi <[email protected]>
bencbartlett pushed a commit to bencbartlett/meep that referenced this issue Sep 9, 2021
@ahoenselaar @stevengj
Fix the binary_partition copy constructor. (NanoComp#1702)
2978063 
* Fix the `binary_partition` copy constructor.

Prevents issues with older compilers.
\NanoComp#1683 NanoComp#1701

* Update src/structure_dump.cpp

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Steven G. Johnson <[email protected]>
bencbartlett pushed a commit to bencbartlett/meep that referenced this issue Sep 9, 2021
@mochen4 @ahoenselaar
@stevengj @oskooi
Enable nonzero k_point in adjoint solver (NanoComp#1705)
6feba73 
* fix factor 2

* fix

* fix

* fix

* kpoint

* fix

* Fix the `binary_partition` copy constructor. (NanoComp#1702)

* Fix the `binary_partition` copy constructor.

Prevents issues with older compilers.
\NanoComp#1683 NanoComp#1701

* Update src/structure_dump.cpp

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Steven G. Johnson <[email protected]>

* single precision test tol

* single precision test tol

* Fix factor of 2 in adjoint gradients when not using complex fields (NanoComp#1704)

* fix factor 2

* fix

* fix

* fix

* single precision test tol

* single precision test tol

* Update python/adjoint/objective.py

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Mo Chen <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>

* assertVectorsClose works for scalars as well as vectors (NanoComp#1712)

* assertVectorsClose works for scalars as well as vectors

* rename ApproxComparisonMixin -> ApproxComparisonTestCase, since it is a subclass of TestCase, and use it as such

* add --with-coverage to control usage of Python coverage tests (NanoComp#1713)

* add --with-coverage to control usage of Python coverage tests

* move  --with-coverage  to correct CI line

* flush subnormals on x86 (NanoComp#1709)

* flush subnormals on x86

* less aggressive error threshold in single precision

* increase single-precision tolerance

* update tols in test_array_metadata

* update for assertVectorsClose rename

* lower tolerance in single precision

* Lower tolerance of CW and eigenfrequency solver tests for single precision (NanoComp#1714)

* lower tolerance of CW and eigenfrequency solver tests for single precision

* remove change in default argument from Python wrappers

* fix factor 2

* fix

* kpoint

* fix

* single precision test tol

* single precision test tol

* using real

* using real

* fix rebase

* fix

* fix

Co-authored-by: Mo Chen <[email protected]>
Co-authored-by: Andreas Hoenselaar <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>
Co-authored-by: Ardavan Oskooi <[email protected]>
mawc2019 pushed a commit to mawc2019/meep that referenced this issue Nov 3, 2021
@ahoenselaar @stevengj @mawc2019
Fix the binary_partition copy constructor. (NanoComp#1702)
f0faf42 
* Fix the `binary_partition` copy constructor.

Prevents issues with older compilers.
\NanoComp#1683 NanoComp#1701

* Update src/structure_dump.cpp

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Steven G. Johnson <[email protected]>
mawc2019 pushed a commit to mawc2019/meep that referenced this issue Nov 3, 2021
@mochen4 @ahoenselaar
@stevengj @oskooi @mawc2019
Enable nonzero k_point in adjoint solver (NanoComp#1705)
3033f38 
* fix factor 2

* fix

* fix

* fix

* kpoint

* fix

* Fix the `binary_partition` copy constructor. (NanoComp#1702)

* Fix the `binary_partition` copy constructor.

Prevents issues with older compilers.
\NanoComp#1683 NanoComp#1701

* Update src/structure_dump.cpp

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Steven G. Johnson <[email protected]>

* single precision test tol

* single precision test tol

* Fix factor of 2 in adjoint gradients when not using complex fields (NanoComp#1704)

* fix factor 2

* fix

* fix

* fix

* single precision test tol

* single precision test tol

* Update python/adjoint/objective.py

Co-authored-by: Steven G. Johnson <[email protected]>

Co-authored-by: Mo Chen <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>

* assertVectorsClose works for scalars as well as vectors (NanoComp#1712)

* assertVectorsClose works for scalars as well as vectors

* rename ApproxComparisonMixin -> ApproxComparisonTestCase, since it is a subclass of TestCase, and use it as such

* add --with-coverage to control usage of Python coverage tests (NanoComp#1713)

* add --with-coverage to control usage of Python coverage tests

* move  --with-coverage  to correct CI line

* flush subnormals on x86 (NanoComp#1709)

* flush subnormals on x86

* less aggressive error threshold in single precision

* increase single-precision tolerance

* update tols in test_array_metadata

* update for assertVectorsClose rename

* lower tolerance in single precision

* Lower tolerance of CW and eigenfrequency solver tests for single precision (NanoComp#1714)

* lower tolerance of CW and eigenfrequency solver tests for single precision

* remove change in default argument from Python wrappers

* fix factor 2

* fix

* kpoint

* fix

* single precision test tol

* single precision test tol

* using real

* using real

* fix rebase

* fix

* fix

Co-authored-by: Mo Chen <[email protected]>
Co-authored-by: Andreas Hoenselaar <[email protected]>
Co-authored-by: Steven G. Johnson <[email protected]>
Co-authored-by: Ardavan Oskooi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the binary_partition copy constructor. ahoenselaar/meep
1 participant
@FiodarM