Warning of sharp corners or cusps #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There should definitely be a way to turn this off. |
|
A boolean argument |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the Harris corner detector from OpenCV is used for detecting sharp corners or cusps in binary images. If a sharp corner or cusp is detected, a warning message will be printed out.
The detection is not successful in every cases. A feature may be mistakenly classified as a sharp corner or cusp if the resolution is too low. On the other hand, a sharp corner or cusp may not be recognized if the angle is smaller than ~30° or larger than ~120°. Changing some parameters can easily increase the true positive rate, but also increase the false positive rate. This issue was partially investigated here.