Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

indexioned rule support #105

Closed
KonoromiHimaries opened this issue Jan 29, 2018 · 11 comments
Closed

indexioned rule support #105

KonoromiHimaries opened this issue Jan 29, 2018 · 11 comments
Labels
archived This thread was archived, open new issues for similar problems. duplicate

Comments

@KonoromiHimaries
Copy link

KonoromiHimaries commented Jan 29, 2018

i have alternative for this
#91

you can add support to indexion rule

example.
[V.2231] [E: ads] [S: ready] [P:2] [Q:75]

V - last version, E - element, S - status, P - priority 1-4, Q - sensitivity of blocking 1-100

2018-01-31-nano przegladarka filtrow
https://github.com/KonoromiHimaries/polish-ads-filter/blob/master/inside-filters/adblock_wewnetrzne.txt

it would be super useful to manage lists for ordinary people
using the scroll bar you could set the blocking degree

or choose only those elements that you want to block and others to disable.

profile packages
gorhill#3651

@jspenguin2017
Copy link
Member

jspenguin2017 commented Jan 29, 2018

Is there a reasonable implementation that exist?

I don't see a reasonable way to handle "priority", but it's possible to handle just a "level" value. Like rules above the set level are ignored.

@elypter
Copy link

elypter commented Jan 30, 2018

i would also love to see a blocking level slider. you could combine stable filters and more risky, generic or experimental ones in the same list and adjust it if too many sites break. this was partially the reason for the feature suggestion to switch lists on or off for individual sites. the current level of the slider will also help to narrow down the filter in question in case of a bug report.

@jspenguin2017
Copy link
Member

jspenguin2017 commented Jan 30, 2018

The "slider" will only control which filter to enable, once a filter is activated it is activated, overriding rules will follow current rules, and that will not change.
I don't want to get things too bloated, although I understand that you want multi-function filters, I think there is a better system to organize this.

@jspenguin2017
Copy link
Member

Most of these suggestions are result of the poor design of the 3rd party panel, which is horrifyingly hard to use once you have more than 5 custom filters.
I think the correct way to fix problems like this is to have a proper filter lists manager, with groups, sorting, sifting, and batch action.
Maybe also filter profiles like we discussed earlier.

I think it's up to the filter maintainers to separate different functionalities to different files, I can probably add a "install filter package" but inline filter hints is not the right way to address the problem IMO.

Either way, this is probably below the end of my todo list, as I have many other features I want to work on first.

@elypter
Copy link

elypter commented Jan 30, 2018

i agree. i imagine it like this:

!&[L: 1-3]
*/ads/banner.jpg

!&[L: 4-10]
*/ads/*

@jspenguin2017
Copy link
Member

Huh, that is actually something to consider.
But I'll say no to the other options (type, quality, etc).

@jspenguin2017 jspenguin2017 added low priority hard available This issue is open for contribution. labels Jan 30, 2018
@jspenguin2017
Copy link
Member

I honestly don't want to implement this, but I would accept a PR.

@jspenguin2017
Copy link
Member

jspenguin2017 commented Jan 30, 2018

I'll remake the 3rd party panel, although the filter levels are for another day.
Any existing tools to make that? I'm thinking about a modified bookmark manager.

@elypter
Copy link

elypter commented Jan 30, 2018

that sounds like a good idea if you find something that is compatible with your new dashboard

@KonoromiHimaries
Copy link
Author

KonoromiHimaries commented Jan 30, 2018

i would also love to see a blocking level slider

blocking level slider per single site in popup panel
of course, keeping the main slider for all sites in the nano adblocker dashboard

that can be a alternative at fair adblocker

img

img

@jspenguin2017
Copy link
Member

jspenguin2017 commented Jan 30, 2018

I think it's ridiculous.
We have talked about this, I will not add per-site switch that affects the entire filters base.

@jspenguin2017 jspenguin2017 added wontfix and removed available This issue is open for contribution. hard low priority under consideration labels Feb 4, 2018
@github-actions github-actions bot added the archived This thread was archived, open new issues for similar problems. label Aug 21, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived This thread was archived, open new issues for similar problems. duplicate
Projects
None yet
Development

No branches or pull requests

4 participants
@elypter @KonoromiHimaries @jspenguin2017 and others