Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hubspot integration template #924

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

ajtrichards
Copy link
Contributor

Added integration template for Hubspot - Tickets

Tested this out using my Hubspot account and syncs have worked as expected.

Screenshot 2023-08-23 at 09 26 30

Copy link
Member

@bastienbeurier bastienbeurier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing this useful sync!

integration-templates/hubspot/hubspot-service-tickets.ts Outdated Show resolved Hide resolved
integration-templates/hubspot/hubspot-service-tickets.ts Outdated Show resolved Hide resolved
integration-templates/hubspot/nango.yaml Outdated Show resolved Hide resolved
}));

if (mappedTickets.length > 0) {
await nango.batchSave<HubspotServiceTicket>(mappedTickets, 'HubspotServiceTicket');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Batch saving all tickets at once can be memory-intensive for large accounts, and result in sync failure.

Ideally, we should batch save after each page.

Copy link
Member

@bastienbeurier bastienbeurier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks a lot for the great contribution!

@bastienbeurier bastienbeurier merged commit e41a28b into NangoHQ:master Aug 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants