feat(server/db): 💾 Add support for connection pool overrides #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRaduan
commented
Apr 26, 2023
packages/server/lib/db/db.config.ts
Outdated
Comment on lines
18
to
20
| pool: { | ||
| min: process.env['NANGO_DB_POOL_MIN'] || 2, | ||
| max: process.env['NANGO_DB_POOL_MAX'] || 7 |
There was a problem hiding this comment.
this code seemed trivial, so I didn't actually test it. Let me know if you want me to test it or there are some automated checks already.
There was a problem hiding this comment.
Don't think there are any actual tests. But, it builds.
|
Thanks a lot for pushing this!! Indeed, we don't have testing in place yet, this is on the roadmap. I'll take some time to test on my side! |
bastienbeurier
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to the discussion held on https://nango-community.slack.com/archives/C04ABR352H0/p1682452663638319.
While using neon.tech (serverless Postgres DB), I noticed that my compute is always on. After debugging it, I found that the Nango server was causing the issue. After a quick chat with @bastienbeurier, we identified the Knex ORM as the culprit.
As per the Knex ORM docs website, it is important to note that the default value of min is 2 only for historical reasons. It can result in problems with stale connections, despite tarn’s default idle connection timeout of 30 seconds, which is only applied when there are more than min active connections. Therefore, it is recommended to set min: 0 so that all idle connections can be terminated.