feat(integrations): add support for Buildium #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
reviewed
Oct 4, 2024
TBonnin
requested changes
Oct 4, 2024
| credentials: | ||
| apiKey: | ||
| type: string | ||
| title: API Key | ||
| description: The API key for your Buildium account | ||
| pattern: '^[a-z0-9_-]+$' | ||
| example: uOq2p+xlgpFdijfV/HqY+EvYpZKHRwlyhGuAVbJIxXs |
There was a problem hiding this comment.
the regex doesn't match the value. It contains + or / for instance. You probably want ^[A-Za-z0-9+/]+$ instead
There was a problem hiding this comment.
aah yes, updated with commit
TBonnin
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
EXT-180