fix(connect): defer token creation after iframe open #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
approved these changes
Oct 3, 2024
| return; | ||
| } | ||
| connectUI.current!.setSessionToken(res.json.data.token); | ||
| }, 10); |
There was a problem hiding this comment.
that's a pretty short value. no? what happen if the call to connect/sessions takes longer than that?
There was a problem hiding this comment.
The call is triggered after 10ms.
The setTimeout is just here to free the main event loop, which means the iframe can be created and the URL loading started, the iframe doesn't have a separate sandbox so it's important that it has time to load and display something.
Then the setTimeout triggers and it takes as much time as it needs.
10ms is not a lot but on a good connection waiting for nothing would be detrimental to UX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow to pass the token after the iframe is created so we can display a loading screen instead of just nothing