fix: disable proxy debug log by default #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
approved these changes
Aug 21, 2024
bastienbeurier
approved these changes
Aug 22, 2024
TBonnin
force-pushed
the
tbonnin/proxy-log-debug
branch
from
861c55f
to
e0a290e
Compare
Pass the header `Debug: true` to /proxy to enable the debug logs
TBonnin
force-pushed
the
tbonnin/proxy-log-debug
branch
from
e0a290e
to
c965627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy requests have debug logs showing by default. This PR is hiding the proxy debug logs which are not very useful unless debugging
Passing the header
Debug: trueto /proxy would enabled the debug logsWithout debug header:
With
Debug: trueheader (like before):Issue ticket number and link
Part of https://linear.app/nango/issue/NAN-1526/improve-proxy-logs
Checklist before requesting a review (skip if just adding/editing APIs & templates)