Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error message for provider key missing #2622

Merged

Conversation

kndwin
Copy link
Contributor

@kndwin kndwin commented Aug 21, 2024

Describe your changes

I spent like an hour trying to understand where to pass this in (had to look through the source code) and thought it'll be an easy PR to push

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

@bastienbeurier
Copy link
Member

Thanks for contributing this @kndwin and sorry for the confusion!

Copy link
Collaborator

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @kndwin
Can I ask what scenario lead to this? Because this error message is shown only when no syncs or actions matched anyway

@kndwin
Copy link
Contributor Author

kndwin commented Aug 21, 2024

Yeah it turns out my <sync_name> I passed in was misspelled anyway

nango dryrun <sync_name> <connection_id>

The error though made me think I didn't pass in the provider config key so went on a long journey to realised I made 2 errors (not passing in --integration-id and misspelling the <sync_name>)

After passing in the --integration-id I had a new error (The sync/action was not executed (I think it was that)) which prompted me to just console log all the args inside the node_module folder of the nango global file and then I noticed my error

(Would be nice actually to suggest the closest name but probably a feature request)

@bodinsamuel
Copy link
Collaborator

yes indeed we should probably suggest a list of syncs if nothing matched. I'll merge this as-is and note to improve this scenario 👌🏻

@bodinsamuel bodinsamuel merged commit a170827 into NangoHQ:master Aug 21, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants