-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): add support for chargebee #2615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason this svg
is not showing up in the app. I've compared with other recently merged integrations and could not spot the difference. Can someone suggest what might be the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hassan254-prog has been dealing with logos a lot. He might know what's going on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding a new svg
file, you will also need to rebuild your frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hassan254-prog has been dealing with logos a lot. He might know what's going on
@edishu LGTM. I’ve left a few small comments inline 👍 |
Co-authored-by: Thomas Bonnin <[email protected]>
Sounds great, I've pushed the changes related to your inline comments. Please take a look and let me know if I need to address anything else. |
@TBonnin @hassan254-prog I've pushed the required changes. Please take a look again. If everything looks fine can we merge this PR? I need use this integration next week and would be great if this gets merged in the source soon. |
Sorry, overlooked your comment #2615 (comment). Pushed the required changes, please take a look. |
Describe your changes
Test
This provider has been used successfully in local development to connect
to chargebee after authorizing using Nango.
The documentation update was reviewed using
npm run docs
and verifyingon localhost.