perf(scheduler): create tasks in parallel

[TBonnin]

Describe your changes

Tasks are currently created by scheduler one by one. We can parallelize the tasks creation to speed up the scheduling transaction

Checklist before requesting a review (skip if just adding/editing APIs & templates)

• I added tests, otherwise the reason is:
• I added observability, otherwise the reason is:
• I added analytics, otherwise the reason is:

[TBonnin]

a bit weird but the PromiseAllSettled result type is PromiseSettleResult<Result<Task>>[]

[bodinsamuel]

Indeed. Looks good, just an open comment about the transaction

[bodinsamuel]

you could have done all of that inside the .map (if that makes more sense)

[TBonnin]

you mean with a then? The goal is not to await for the result in the map

[bodinsamuel]

I meant keeping the code exactly the same but inside the map, since you don't kill the transaction

schedules.value.map(async (schedule) => {
      const task = await tasks.create(trx, {
          scheduleId: schedule.id,
          startsAfter: new Date(),
          name: `${schedule.name}:${new Date().toISOString()}`,
          createdToStartedTimeoutSecs: schedule.createdToStartedTimeoutSecs,
          startedToCompletedTimeoutSecs: schedule.startedToCompletedTimeoutSecs,
          heartbeatTimeoutSecs: schedule.heartbeatTimeoutSecs
      });
      if (task.isErr()) 
      [...]
  });

[TBonnin]

I see. But you are awaiting while iterating through the list. no?

[bodinsamuel]

should not no, this is a common pattern await Promise.all(array.map(async))

[bodinsamuel]

Wait my comment was not sent 🤔
I was saying (before and after this pr) you are not killing the transaction if any tasks fails, is it on purpose?

[TBonnin]

yes it is on purpose. Failing to create a task should not prevent other tasks to be created.
The same scheduling logic will try to create the task again in the next iteration if needed