Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): [nan-1247] add checkr post connection script #2370

Conversation

khaliqgant
Copy link
Member

Describe your changes

In integration scripts it is useful to know if the checkr account has account hierarchy enabled or not. Add a post connection script to automatically inject the boolean.

Issue ticket number and link

NAN-1247

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented Jun 19, 2024

access_token = connection.credentials.access_token;
} else {
return;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can slightly simplify like this I think:

const access_token: string | undefined = connection.credentials.access_token;
if (!access_token) {
  return;
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. TS complains about this because access_token isn't always guaranteed to exist on credentials.

@khaliqgant khaliqgant merged commit bbca613 into master Jun 20, 2024
20 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1247-checkr-check-if-hierarchy-is-account-enabled-in-a-post branch June 20, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants