Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nango-yaml): fine tune parsing #2366

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

bodinsamuel
Copy link
Collaborator

Describe your changes

Fix more edge cases and fine tune messaging

  • Handle union type in input/output correctly
  • Fix: Action template without an input
  • Be more explicit about unsupported typescript syntax
  • Do not complain about anonymous model in case of union, it's a legitimate use case of anonymous model
  • Do not complain about action input model reuse, it's too noisy to be useful

@bodinsamuel bodinsamuel self-assigned this Jun 19, 2024
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustment for clarity in the error response requested

@khaliqgant khaliqgant self-requested a review June 19, 2024 09:26
@bodinsamuel
Copy link
Collaborator Author

Thanks @khaliqgant 👌🏻

@bodinsamuel bodinsamuel merged commit ce4e85a into master Jun 19, 2024
20 checks passed
@bodinsamuel bodinsamuel deleted the fix/cli-more-edge-cases branch June 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants