fix(integration-templates): add workflow and edit existing #2337
Conversation
| unset parts[-2] | ||
| fi | ||
|
|
||
| dir=$(IFS=/; echo "${parts[*]}") |
There was a problem hiding this comment.
if you want more bash magic I think you can do this with a one liner:
dir=${dir%/*/*}/${dir##*/}
Removing the last 2 elements of the path with the first curly bracket and re-adding the last element in the second
| @@ -0,0 +1,39 @@ | |||
| name: 'Sync Integration Templates' | |||
There was a problem hiding this comment.
I am not sure I follow why we need this extra action. Aren't the merge triggering the templates upload action above done by us, even on external contributions? if yes what's the permissions issue?
There was a problem hiding this comment.
It is more of a fail safe than anything. It’s a force sync of all templates since the regular one looks just for changed files.
For some reason this action contribution #2242 didnt get uploaded to s3. In that instance we need a way to sync integration templates. I need to look into exactly why it failed but I assumed it was a permissions issue but not 100% sure.
There was a problem hiding this comment.
suggestion for future: this could be done at the start of the server process instead
| @@ -0,0 +1,39 @@ | |||
| name: 'Sync Integration Templates' | |||
There was a problem hiding this comment.
suggestion for future: this could be done at the start of the server process instead
Describe your changes
With relative imports the logic needs to be adjusted some. Also adds a workflow to upload all templates as a safeguard as when a template is made by an external contributor it doesn't get uploaded due to lack of permissions
Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)