fix: event should be emitted when task is created by scheduling worker #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Jun 13, 2024
| @@ -7,7 +7,7 @@ import { setTimeout } from 'node:timers/promises'; | |||
| import type knex from 'knex'; | |||
| import { logger } from '../../utils/logger.js'; | |||
|
|
|||
| interface MessageOut { | |||
| interface ExpiredTasksMessage { | |||
There was a problem hiding this comment.
unrelated but wanted to be consistent with the naming of the same notifying mechanism in the monitor and scheduling worker
bodinsamuel
approved these changes
Jun 13, 2024
khaliqgant
approved these changes
Jun 13, 2024
Created task events are useful for long polling to be instantly notified of a new created tasks.
TBonnin
force-pushed
the
tbonnin/fix-scheduling-event
branch
from
643fd53
to
18d37f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created task events are useful for long polling to be instantly notified of a new created tasks.
Checklist before requesting a review (skip if just adding/editing APIs & templates)