feat(orchestrator): pause/unpause/delete sync #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBonnin
commented
Jun 7, 2024
| @@ -15,7 +15,8 @@ interface ScheduleStateTransition { | |||
| export const validScheduleStateTransitions = [ | |||
| { from: 'STARTED', to: 'PAUSED' }, | |||
| { from: 'STARTED', to: 'DELETED' }, | |||
| { from: 'PAUSED', to: 'STARTED' } | |||
| { from: 'PAUSED', to: 'STARTED' }, | |||
| { from: 'PAUSED', to: 'DELETED' } | |||
There was a problem hiding this comment.
Missed state transition. Deleting a paused schedule should be allowed
TBonnin
force-pushed
the
tbonnin/orchestrator-schedule-pause
branch
from
1529f72
to
aba00f1
Compare
TBonnin
commented
Jun 7, 2024
| @@ -344,7 +370,6 @@ export class OrchestratorClient { | |||
| } | |||
| } | |||
|
|
|||
| //TODO: rename to cancelTask? | |||
There was a problem hiding this comment.
I don't think we are gonna need a cancelSync.
There was a problem hiding this comment.
Can you explain what you mean by this exactly?
There was a problem hiding this comment.
The cancel function is cancelling a task (aka: a sync execution). Yesterday I though we might need to have a cancelSchedule so I added a TODO to rename the existing function to cancelTask. But it happens that we don't cancel schedule (which are only paused/unpaused or deleted), only tasks/jobs. So keeping the name cancel for the function is ok for now
TBonnin
force-pushed
the
tbonnin/orchestrator-schedule-pause
branch
from
aba00f1
to
af26ce7
Compare
3 tasks
bodinsamuel
reviewed
Jun 10, 2024
| if (schedule.isErr()) { | ||
| return res.status(500).json({ error: { code: 'recurring_failed', message: schedule.error.message } }); | ||
| } | ||
| return res.status(201).json({ scheduleId: schedule.value.id }); |
There was a problem hiding this comment.
nitpick: 200 might be more accurate
TBonnin
force-pushed
the
tbonnin/orchestrator-schedule-pause
branch
from
01ad8ca
to
be91544
Compare
TBonnin
added a commit
that referenced
this pull request
Jun 10, 2024
Built on top of #2289 (please review it first) Implementing `runSyncCommand` in orchestrator. I am not sure I understand the split of responsibility between `sync.client` and `orchestrator.service`. `sync.client runSyncCommand` is called by `orchestration.service runSyncCommand` but it is also called directly in a few places: for example [here](https://github.com/NangoHQ/nango/blob/dee08827d78616c013c4f3e27ddad53f46a7a298/packages/jobs/lib/crons/autoIdleDemo.ts#L81) and [here](https://github.com/NangoHQ/nango/blob/dee08827d78616c013c4f3e27ddad53f46a7a298/packages/server/lib/controllers/sync.controller.ts#L746). Same thing happens with the creation of sync schedules where there are 3 mains path to `startContinuous`, `deploys` goes through the `orchestrator.service` but `connectionCreatedHook` calls the `sync.client` directly 😢 This make it very hard to have clean transition code. I have created a temporary function to take care of the feature flag branching. Code will be refactored once temporal is removed. For now no schedule is being created in the orchestrator so all commands would fail if the flag is turned on. Next PR will add the creation of schedules. ## Checklist before requesting a review (skip if just adding/editing APIs & templates) - [ ] I added tests, otherwise the reason is: - [ ] I added observability, otherwise the reason is: - [ ] I added analytics, otherwise the reason is:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding way to pause/unpause/delete a schedule in the orchestrator
Also allowing to create a schedule in paused state. This is going to be required to support sync auto_start
Issue ticket number and link
Checklist before requesting a review (skip if just adding/editing APIs & templates)