-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(logs): feedback #4 #2269
fix(logs): feedback #4 #2269
Conversation
@@ -120,11 +121,17 @@ export default function Syncs({ syncs, connection, provider, reload, loaded, syn | |||
setShowTriggerFullLoader(false); | |||
}; | |||
|
|||
const renderBubble = (bubbleType: ReactNode, sync: SyncResponse) => { | |||
const RenderBubble = ({ sync, children }: { sync: SyncResponse; children: ReactNode }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed that to a proper component for clarification
Will review this first thing tomorrow |
@@ -265,7 +266,12 @@ We could not retrieve and/or refresh your access token due to the following erro | |||
<ErrorCircle /> | |||
<span className="ml-2">There was an error refreshing the credentials</span> | |||
<Link | |||
to={`/${env}/activity?activity_log_id=${connectionResponse.errorLog.activity_log_id}&connection=${connectionResponse.connection.connection_id}&date=${getSimpleDate(connectionResponse.errorLog?.created_at?.toString())}`} | |||
to={getLogsUrl({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bad-link.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, thanks for testing that looking into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any issue on my side, however I noted the Failed state does not appear if the schedule is paused
Screen.Recording.2024-06-06.at.11.36.21.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed |
Describe your changes
Changes:
Bonus
Date.now
instead of drifting.