fix(logs): feedback #4 #2269
Merged
fix(logs): feedback #4 #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodinsamuel
commented
Jun 5, 2024
| @@ -120,11 +121,17 @@ export default function Syncs({ syncs, connection, provider, reload, loaded, syn | |||
| setShowTriggerFullLoader(false); | |||
| }; | |||
|
|
|||
| const renderBubble = (bubbleType: ReactNode, sync: SyncResponse) => { | |||
| const RenderBubble = ({ sync, children }: { sync: SyncResponse; children: ReactNode }) => { | |||
There was a problem hiding this comment.
Changed that to a proper component for clarification
|
Will review this first thing tomorrow |
TBonnin
approved these changes
Jun 6, 2024
khaliqgant
reviewed
Jun 6, 2024
khaliqgant
reviewed
Jun 6, 2024
| @@ -265,7 +266,12 @@ We could not retrieve and/or refresh your access token due to the following erro | |||
| <ErrorCircle /> | |||
| <span className="ml-2">There was an error refreshing the credentials</span> | |||
| <Link | |||
| to={`/${env}/activity?activity_log_id=${connectionResponse.errorLog.activity_log_id}&connection=${connectionResponse.connection.connection_id}&date=${getSimpleDate(connectionResponse.errorLog?.created_at?.toString())}`} | |||
| to={getLogsUrl({ | |||
There was a problem hiding this comment.
When clicking from the connections page I get this
which in of itself the x looks misaligned
There was a problem hiding this comment.
weird, thanks for testing that looking into it
There was a problem hiding this comment.
I don't have any issue on my side, however I noted the Failed state does not appear if the schedule is paused
Screen.Recording.2024-06-06.at.11.36.21.mov
khaliqgant
reviewed
Jun 6, 2024
Fixed |
khaliqgant
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes:
Bonus
Date.nowinstead of drifting.