Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server.proxy): [nan-1049] if the response not chunked manually piece the response together #2228

Conversation

khaliqgant
Copy link
Member

Describe your changes

Issue reported in the community. The proxy assumed that providers send back the data chunked but that is not the case. When it is not chunked we need to manually piece together the chunks and parse the string data.

Issue ticket number and link

NAN-1049

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • I added observability, otherwise the reason is:
  • I added analytics, otherwise the reason is:

Copy link

linear bot commented May 30, 2024

Copy link
Collaborator

@TBonnin TBonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit annoying that we have to deal with provider malfunctioning APIs, sending back chunked response without setting the transfer-encoding: chunked header

@khaliqgant
Copy link
Member Author

a bit annoying that we have to deal with provider malfunctioning APIs, sending back chunked response without setting the transfer-encoding: chunked header

Yeah and it is only for certain api endpoints as well 😩

@khaliqgant khaliqgant merged commit 79aa650 into master May 30, 2024
21 checks passed
@khaliqgant khaliqgant deleted the khaliq/nan-1049-when-the-proxy-receives-a-string-as-a-response-it-isnt branch May 30, 2024 17:53
@AnandChowdhary
Copy link
Contributor

Sorry you had to deal with this weird inconsistency and thank you so much for your hard work, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants