-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): add support for datev #2223
Conversation
It is much simpler to understand how DATEV Online API handles authentication from the following postman collection |
|
||
## API gotchas | ||
|
||
- An `access_token` is valid for 15 minutes, while the `refresh_token` is valid for 11 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's quite short, I'm not sure we will be able to keep this alive (cc @khaliqgant)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we won't, also good reason to keep the refresh logic in the getConnectionCredentials
call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have a way to compute expiration date, store it in DB and use this date to refresh only the one that will expires soon
@@ -466,6 +466,30 @@ contentstack: | |||
authorization_url: https://${connectionConfig.subdomain}.contentstack.com/apps/${connectionConfig.appId}/authorize | |||
token_url: https://${connectionConfig.subdomain}.contentstack.com/apps-api/apps/token | |||
docs: https://docs.nango.dev/integrations/all/contentstack | |||
#Untested configuration. Please reach out if you have a test account that we can use to test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it nice to have this comment :D
Most likely the customer that will need it will reach out to us when time comes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bodinsamuel, thank you for pointing this out. @bastienbeurier had suggested we add this comment here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh okay, miss communication then let's keep it that way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should add another pr to revert this
2ab8841
to
2cdcde6
Compare
authorization_url: https://login.datev.de/openid/authorize | ||
token_url: https://api.datev.de/token | ||
token_request_auth_method: basic | ||
scope_seprator: ' ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just asking, but doesn't that typo have any side effects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, I'll fix that 👌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another one in another section btw. Thanks
Describe your changes
Issue ticket number and link
EXT-76
Test
The documentation update was reviewed using
npm run docs
and verifying on localhost.