-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): messages infinite scroll and live refresh #2214
Changes from all commits
5985ec0
9c46e83
533c4f4
e216e45
ea09b22
a0c68bb
f34b3e4
7c2f317
e0a660b
8fadf3e
fe0ffb7
91da4c6
176ca2a
b9610c8
9c1e614
1766560
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,7 +56,7 @@ export const ShowMessage: React.FC<{ message: MessageRow }> = ({ message }) => { | |
<div className="overflow-x-auto"> | ||
<h4 className="font-semibold text-sm mb-2">Payload</h4> | ||
|
||
{message.meta ? ( | ||
{message.meta || message.error ? ( | ||
<div className="text-gray-400 text-sm bg-pure-black py-2"> | ||
<Prism | ||
language="json" | ||
|
@@ -66,7 +66,7 @@ export const ShowMessage: React.FC<{ message: MessageRow }> = ({ message }) => { | |
return { code: { padding: '0', whiteSpace: 'pre-wrap' } }; | ||
}} | ||
> | ||
{JSON.stringify({ error: message.error || undefined, output: message.meta || undefined }, null, 2)} | ||
{JSON.stringify({ error: message.error?.message || undefined, output: message.meta || undefined }, null, 2)} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes because messge.error can be |
||
</Prism> | ||
</div> | ||
) : ( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a link to elastic/elasticsearch#29449 Might be handy if we ever run into the limitation mentioned in the issue