Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: making the scheduler db not rely on env vars #2171

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: making the scheduler db not rely on env vars #2171

merged 1 commit into from
May 21, 2024

Commits on May 21, 2024

  1. chore: making the scheduler db not rely on env vars 

    configuring the scheduler, which is a independant library, with env vars
make it harder to understand where things are being configured and how.
We ran into issues with the records package regarding default
env vars value and behavior if/when not configured.
With this commit the db url and schema are passed into the scheduler
package and we don't have a global db object within the package.
The `Tasks` function are now all taking `db` as their first parameter,
this has the nice side effect to make it possible to run them in a
transaction if needed.
    @TBonnin
    TBonnin committed May 21, 2024
    Configuration menu
    Copy the full SHA
    81fa54c View commit details
    Browse the repository at this point in the history