Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete syncs when deleting a connection, provider #847

Closed
2 tasks done
khaliqgant opened this issue Jul 26, 2023 · 0 comments · Fixed by #848
Closed
2 tasks done

Delete syncs when deleting a connection, provider #847

khaliqgant opened this issue Jul 26, 2023 · 0 comments · Fixed by #848
Assignees
Labels
bug Something isn't working

Comments

@khaliqgant
Copy link
Member

khaliqgant commented Jul 26, 2023

Saw in temporal there are a lot less sync schedules than what is in the database and realized that logic was in the code to delete the schedule in temporal on connection delete or config delete but was not there to delete the sync in the database. This was because before soft deletes objects cascaded. We need to explicitly handle deleting all objects on connection delete and config delete.

This should fix that logic and also delete stale syncs, schedules, jobs, and data records.

  • Clean up stale syncs
  • Fix logic
@khaliqgant khaliqgant self-assigned this Jul 26, 2023
@khaliqgant khaliqgant added the bug Something isn't working label Jul 26, 2023
khaliqgant added a commit that referenced this issue Jul 26, 2023
khaliqgant added a commit that referenced this issue Jul 26, 2023
khaliqgant added a commit that referenced this issue Jul 27, 2023
* [gh-#847] handle connections and config deletion

* [gh-#847] delete syncs for config

* [gh-#847] delete stale syncs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant