Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #783

Closed
khaliqgant opened this issue Jul 16, 2023 · 0 comments · Fixed by #784
Closed

Improve error handling #783

khaliqgant opened this issue Jul 16, 2023 · 0 comments · Fixed by #784
Assignees
@khaliqgant
Labels
enhancement New feature or request

Comments

@khaliqgant
Copy link
Member

khaliqgant commented Jul 16, 2023 •
edited
Loading

  • Some places are missing important pieces of information in the event of an error

Should handle better:

  • Also includes the release version in the sentry reporting
@khaliqgant khaliqgant self-assigned this Jul 16, 2023
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] spell unknown correctly
f6acbc2
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] update schedule gets logged to activity log on success or f…
62a8261 
…ailure
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] getConnection throws error on missing params
f85d8b9
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] more detail in problem upserting error
cb837d3
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] cast as number
b56e8a6
@khaliqgant khaliqgant mentioned this issue Jul 16, 2023
Merged
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] await schedule update
4d52245
khaliqgant added a commit that referenced this issue Jul 16, 2023
@khaliqgant
[gh-#783] quote names for better readability
12d197e
khaliqgant added a commit that referenced this issue Jul 17, 2023
@khaliqgant
[gh-#783] use errorManager instead of just a console log
090355b
khaliqgant added a commit that referenced this issue Jul 17, 2023
@khaliqgant
[gh-#783] init sentry in try catch
b9fedae
khaliqgant added a commit that referenced this issue Jul 17, 2023
@khaliqgant
[gh-#783] get release as part of sentry reporting
cbdb528
khaliqgant added a commit that referenced this issue Jul 17, 2023
@khaliqgant
Gh #783 improve error handling (#784)
9b87d76 
* [gh-#783] spell unknown correctly

* [gh-#783] update schedule gets logged to activity log on success or failure

* [gh-#783] getConnection throws error on missing params

* [gh-#783] more detail in problem upserting error

* [gh-#783] cast as number

* [gh-#783] await schedule update

* [gh-#783] quote names for better readability

* [gh-#783] use errorManager instead of just a console log

* [gh-#783] init sentry in try catch

* [gh-#783] get release as part of sentry reporting
khaliqgant added a commit that referenced this issue Jul 18, 2023
@khaliqgant
[gh-#783] better metadata for the error
0131517
khaliqgant added a commit that referenced this issue Jul 18, 2023
@khaliqgant
[gh-#783] add half day parsing
65d4c7a
khaliqgant added a commit that referenced this issue Jul 18, 2023
@khaliqgant
Gh #783 more context (#795)
a95d434 
* [gh-#783] better metadata for the error

* [gh-#783] add half day parsing
khaliqgant added a commit that referenced this issue Jul 18, 2023
@khaliqgant
[gh-#783] every day handled
ecf1cf0
khaliqgant added a commit that referenced this issue Jul 19, 2023
@khaliqgant
[gh-#783] report error
1e59ddd
@bastienbeurier bastienbeurier added the enhancement New feature or request label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khaliqgant khaliqgant

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gh #783 improve error handling NangoHQ/nango
2 participants
@khaliqgant @bastienbeurier