fix: make meta param optional in log client http method

NangoHQ · Aug 26, 2024 · 046253a · 046253a
1 parent 652ab70
commit 046253a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/packages/logs/lib/client.ts b/packages/logs/lib/client.ts
@@ -80,17 +80,24 @@ export class LogContextStateless {
         });
     }
 
+    async http(
+        message: string,
+        data: {
+            request: MessageRow['request'];
+            response: MessageRow['response'];
+            meta?: MessageRow['meta'];
+        }
+    ): Promise<boolean> {
+        const level: MessageRow['level'] = data.response && data.response.code >= 400 ? 'error' : 'info';
+        return await this.log({ type: 'http', level, message, ...data, source: 'internal' });
+    }
+
     /**
      * @deprecated Only there for retro compat
      */
     async trace(message: string, meta: MessageMeta | null = null): Promise<boolean> {
         return await this.log({ type: 'log', level: 'debug', message, meta, source: 'internal' });
     }
-
-    async http(message: string, data: Pick<MessageRow, 'request' | 'response' | 'meta'>): Promise<boolean> {
-        const level: MessageRow['level'] = data.response && data.response.code >= 400 ? 'error' : 'info';
-        return await this.log({ type: 'http', level, message, ...data, source: 'internal' });
-    }
 }
 
 /**

diff --git a/packages/server/lib/controllers/proxy.controller.ts b/packages/server/lib/controllers/proxy.controller.ts
@@ -239,7 +239,6 @@ class ProxyController {
     }) {
         const safeHeaders = proxyService.stripSensitiveHeaders(config.headers, config);
         await logCtx.http(`${config.method.toUpperCase()} ${url} was successful`, {
-            meta: null,
             request: {
                 method: config.method,
                 url,