Fix re-encoding not ugoira zip files #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nandaka
reviewed
Dec 3, 2023
| @@ -480,7 +480,7 @@ def process_ugoira_local(caller, config): | |||
| zip_name = os.path.splitext(os.path.basename(zip))[0] | |||
| zip_dir = os.path.dirname(zip) | |||
| image_id = zip_name.partition("_")[0] | |||
| if image_id not in list_done: | |||
| if 'ugoira' in zip_name and image_id not in list_done: | |||
There was a problem hiding this comment.
this is assuming the zip file will always contains ugoira in the filename, right?
There was a problem hiding this comment.
Yes.
According to my observation, all ugoira downloaded are in format
{id}_ugoira{resolution} - {name}.zip
But file attached in fanbox usually do not contain "ugoira" in filename, such as
189281_p0_7RHGqTqoO0JzAJg23uGWPl9C - 過去絵-サイド高画質版-改.zip.
FIlter by "ugoira" should be a acceptable method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix issue #1312