This repository has been archived by the owner on Jan 24, 2021. It is now read-only.
Removed ADATS dependency in NancyInternalConfiguration #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
|
Needs a rebase |
thecodejunkie
force-pushed
the
remove-adats-dependency-in-nancyinternalconfiguration
branch
from
135c000
to
6fbce8e
Compare
thecodejunkie
force-pushed
the
remove-adats-dependency-in-nancyinternalconfiguration
branch
from
6fbce8e
to
fcfa2a0
Compare
|
Rebased |
| ViewFactory = typeof(DefaultViewFactory), | ||
| ViewResolver = typeof(DefaultViewResolver), | ||
| ViewCache = typeof(DefaultViewCache), | ||
| ViewLocationProvider = typeof(FileSystemViewLocationProvider), |
There was a problem hiding this comment.
Only thing I can see that happened here is alphabetical sorting...
khellang
added a commit
that referenced
this pull request
Feb 7, 2016
…n-nancyinternalconfiguration Removed ADATS dependency in NancyInternalConfiguration
|
YOLO! 😁 |
thecodejunkie
deleted the
remove-adats-dependency-in-nancyinternalconfiguration
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #2221
This one was a bit tricky as we could simply not just take a constructor dependency on
ITypeCataloginNancyInternalConfigurationbecause of theDefaultmember andWithOverrides-method. I used the same approach that was taken in the #1846 spike. TheInternalConfigurationproperty, onNancyBoostrapperBase<T>changed from plainNancyInternalConfigurationreturn type intoFunc<ITypeCatalog, NancyInternalConfiguration>so that we can inject the correctITypeCataloginto itThis also meant that I had to update how the
WithOverridesmethod was designed internally. It also meant that I had to reworkConfigurableBootstrapperworked. Previously I did modify aNancyInternalConfigurationinstance, but it can not do that anymore because of the signature change on the bootstrapper. So instead the configurator build up a list ofAction<NancyInternalConfiguration>which is then applied, one-by-one, on top of theNancyInternalConfigurationinstance that theConfigurableBootstrapperwill end up using.