Fix sorting with thousands separators in value (#3162)

NamelessMC · Jan 10, 2023 · 5692494 · 5692494
1 parent 61c9c51
commit 5692494
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/core/classes/Misc/Placeholders.php b/core/classes/Misc/Placeholders.php
@@ -124,7 +124,7 @@ public function getLeaderboardData(int $server_id, string $placeholder_name): ar
         $sort = $this->getPlaceholder($server_id, sha1($placeholder_name))->leaderboard_sort;
 
         // We have to add 0 to value so mysql converts from the TEXT field to an integer value
-        $leaderboard_data = $this->_db->query("SELECT * FROM nl2_users_placeholders WHERE name = ? AND server_id = ? ORDER BY value + 0 {$sort} LIMIT 50", [$placeholder_name, $server_id]);
+        $leaderboard_data = $this->_db->query("SELECT * FROM nl2_users_placeholders WHERE name = ? AND server_id = ? ORDER BY REPLACE(value, ',', '') + 0 {$sort} LIMIT 50", [$placeholder_name, $server_id]);
 
         if (!$leaderboard_data->count()) {
             return [];