Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No message when PR is valid #26

Closed
smutel opened this issue Sep 18, 2021 · 1 comment
Closed

No message when PR is valid #26

smutel opened this issue Sep 18, 2021 · 1 comment

Comments

@smutel
Copy link
Contributor

smutel commented Sep 18, 2021

Hello,

If I understand the code correctly, the message below

log.Printf("Pull request %d is a conventional PR!", pullRequest.GetNumber())
should be written when the PR is valid.

But if you check this PR: smutel/terraform-provider-netbox#63

  • No message is displayed in the PR check
  • This PR is not valid in fact ... because it is not link to an issue
@Namchee
Copy link
Owner

Namchee commented Sep 19, 2021

Hi, thanks for filing an issue. I'm sorry for the issue you've encountered.

Since the error log shows nothing, I realized that it's really hard to debug errors when it happens 😅 . I'll try to be honest here, I haven't done any thorough test on my local setup as I lack knowledge back then (yeah, this code is almost 1 year old). I'm currently planning to rewrite this tool in near future.

We need to log the error for debugging and I've noticed that you've submitted the PR for it!

Since you've opened #28, I'm going to close this issue and continue the discussion there.

@Namchee Namchee closed this as completed Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants