Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Improve error messages #28

Merged
merged 2 commits into from
Sep 19, 2021
Merged

enh: Improve error messages #28

merged 2 commits into from
Sep 19, 2021

Conversation

smutel
Copy link
Contributor

@smutel smutel commented Sep 18, 2021

Fix #27

Namchee
Namchee requested changes Sep 19, 2021
View reviewed changes
main.go Show resolved Hide resolved
@Namchee Namchee mentioned this pull request Sep 19, 2021
Closed
@smutel smutel marked this pull request as draft September 19, 2021 08:42
@smutel smutel marked this pull request as ready for review September 19, 2021 09:07
@smutel smutel mentioned this pull request Sep 19, 2021
Merged
@smutel smutel marked this pull request as draft September 19, 2021 09:33
@smutel smutel marked this pull request as ready for review September 19, 2021 09:34
@Namchee Namchee self-requested a review September 19, 2021 10:30
Namchee
Namchee requested changes Sep 19, 2021
View reviewed changes
main.go Outdated Show resolved Hide resolved
@Namchee Namchee self-requested a review September 19, 2021 13:38
Namchee
Namchee approved these changes Sep 19, 2021
View reviewed changes
Copy link
Owner

@Namchee Namchee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Whoops, I'm just gonna bypass the PR for now

@Namchee Namchee merged commit ef5ff90 into Namchee:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Namchee Namchee Namchee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve message "Failed to close pull request"
2 participants
@smutel @Namchee