feat: Added Home and Shop pages #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for bookztron-dev-branch ready! 🔨 Explore the source changes: fe4fdbd 🔍 Inspect the deploy log: https://app.netlify.com/sites/bookztron-dev-branch/deploys/622dc6c6bace8f0008a2856c 😎 Browse the preview: https://deploy-preview-1--bookztron-dev-branch.netlify.app/ |
Ankur9669
suggested changes
Mar 12, 2022
| { | ||
| const [ productsAvailableList, dispatchSortedProductsList] = useReducer(productsOrderFunc,productList) | ||
| const [ productFilterOptions, dispatchProductFilterOptions ] = useReducer(updateProductFilters,filterOptionsObject) | ||
|
|
There was a problem hiding this comment.
Suggestion: I think this violates the rules of hooks read this https://reactjs.org/docs/hooks-rules.html
There was a problem hiding this comment.
I believe no rules were broken, I called useReducer at the top level of a component. Would be great if you can elaborate a little more 😅
mehulsatardekar
approved these changes
Mar 13, 2022
Naman-Saxena1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Home and Shop Pages with all working filters
I understand that I made a mistake of adding both pages in 1 PR but I can't revert it because everything is inter-connected and site will start breaking if I unstage some files. Also it will be un-manageable to track all files if I start unstaging them because there are a lot of files.
So I understand if you can skim through code, just to check if everything looks fine.
From next PR I will make sure to create small PRs 😅
Thanks! 😄
Genre Cards
New Arrivals
Footer
Shop Page