Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init node basic version #1

Merged
merged 5 commits into from
Apr 16, 2024
Merged

init node basic version #1

merged 5 commits into from
Apr 16, 2024

Conversation

sglk123
Copy link

@sglk123 sglk123 commented Apr 16, 2024

node init version

Copy link

@ivan-xin ivan-xin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For project progress, Merge into master of poc_1, Please fix the problem later

/// create arc zchronod node
let arc_zchronod: ZchronodArc = Arc::new(Zchronod {});

tokio::task::spawn(zchronod::p2p_event_loop(arc_zchronod.clone()));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these two tasks be carried out as expected?

self.config = config;
self
}

Copy link

@ivan-xin ivan-xin Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add necessary comments

ReceiveMessage::Request(data, res) => {
res.respond(data).await.unwrap();
}
oth => panic!("unexpected: {oth:?}"),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improper naming


impl ZchronodConfig {
pub fn load_config(path: PathBuf) -> ZchronodConfigResult<ZchronodConfig> {
let p: &Path = path.as_ref();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improper naming

@ivan-xin ivan-xin merged commit 9d556e3 into NagaraTech:poc_1 Apr 16, 2024
1 check passed
@ai-chen2050 ai-chen2050 mentioned this pull request May 8, 2024
ai-chen2050 added a commit that referenced this pull request May 8, 2024
Sprint 01: new features

This pull request mainly contains two features:

init node basic version. Merge pull request init node basic version #1 from sglk123/poc_1
feat: add new vlc-dag demos of poc. Merge pull request feat: add new vlc-dag demos of poc #3 from NagaraTech/feat/vlc-dag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants