-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init node basic version #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For project progress, Merge into master of poc_1, Please fix the problem later
/// create arc zchronod node | ||
let arc_zchronod: ZchronodArc = Arc::new(Zchronod {}); | ||
|
||
tokio::task::spawn(zchronod::p2p_event_loop(arc_zchronod.clone())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will these two tasks be carried out as expected?
self.config = config; | ||
self | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add necessary comments
ReceiveMessage::Request(data, res) => { | ||
res.respond(data).await.unwrap(); | ||
} | ||
oth => panic!("unexpected: {oth:?}"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improper naming
|
||
impl ZchronodConfig { | ||
pub fn load_config(path: PathBuf) -> ZchronodConfigResult<ZchronodConfig> { | ||
let p: &Path = path.as_ref(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improper naming
node init version